RFR: JDK-8301180: Replace NULL with nullptr in share/gc/parallel/ [v2]
Johan Sjölen
jsjolen at openjdk.org
Fri Jan 27 10:49:51 UTC 2023
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/gc/parallel/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>
> Here are some typical things to look out for:
>
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>
> An example of this:
>
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
>
>
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
>
> Thanks!
Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- Merge remote-tracking branch 'origin/master' into JDK-8301180
- Replace NULL with nullptr in share/gc/parallel/
-------------
Changes: https://git.openjdk.org/jdk/pull/12227/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12227&range=01
Stats: 224 lines in 30 files changed: 0 ins; 0 del; 224 mod
Patch: https://git.openjdk.org/jdk/pull/12227.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12227/head:pull/12227
PR: https://git.openjdk.org/jdk/pull/12227
More information about the hotspot-gc-dev
mailing list