RFR: 8311514: Incorrect regex in TestMetaSpaceLog.java [v2]

Thomas Stuefe stuefe at openjdk.org
Thu Jul 6 13:38:56 UTC 2023


On Thu, 6 Jul 2023 11:17:15 GMT, Daohan Qu <dqu at openjdk.org> wrote:

>> The regex in jtreg test `TestMetaSpaceLog.java` is intended to capture the metaspace size before and after the reclamation. But it captures the wrong value. which might cause this test to always pass. The results of the capture can be displayed using a visualization tool.
>> 
>> Before this patch:
>> <img width="1128" alt="屏幕快照 2023-07-06 17 18 15" src="https://github.com/openjdk/jdk/assets/18374295/4e3b6606-24b3-4d7f-a70d-f312cb867fbf">
>> 
>> After this patch:
>> <img width="1125" alt="屏幕快照 2023-07-06 17 18 25" src="https://github.com/openjdk/jdk/assets/18374295/b100018e-2c39-4154-9ec7-80e5eedc212e">
>
> Daohan Qu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Match more parts of the metaspace change log

Can you please use `\d+` for numbers?
Also, maybe define `([0-9]+)K` as substring once and assemble the regex from that?

-------------

Changes requested by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14782#pullrequestreview-1516570640


More information about the hotspot-gc-dev mailing list