RFR: 8311646: ZGC: LIR_OpZStoreBarrier::_info shadows LIR_Op::_info

[Kim Barrett]

On Mon, 10 Jul 2023 19:13:32 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

> [JDK-8311646](https://bugs.openjdk.org/browse/JDK-8311646)
> 
> In LIR_OpZStoreBarrier, SonarCloud reports:
>  Field "_info" shadows a field of the same name in base class "LIR_Op".
> 
> Updates LIR_OpZStoreBarrier to use the superclass `_info` instead
> 
> Additional testing:
> - [x] Linux x86_64 fastdebug `tier2`
> - [x] Linux x86_64 release `tier2`
> - [x] Linux x86_64 fastdebug `test/hotspot/jtreg/gc/z`
> - [x] Linux x86_64 release `test/hotspot/jtreg/gc/z`
> - [x] Linux x86_64 fastdebug `gtest:all`
> - [x] Linux x86_64 release `gtest:all`

I agree the old code looks suspect, and this change looks good to me. However,
it would be good to get an opinion from one of the genzgc folks, because the
`/* info */` comment makes it look like the weirdness is intentional. Though
maybe it was just cribbed from the similar load that was fixed by JDK-8278141.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14816#pullrequestreview-1540743600