RFR: 8311978: Shenandoah: Create abstraction over heap metrics for heuristics [v9]

[Aleksey Shipilev]

On Fri, 21 Jul 2023 17:34:17 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> This change introduces a new interface `ShenandoahHeapStats`. Presently, the interface is implemented by `ShenandoahHeap`. The generational mode for Shenandoah will provide a new implementation of this interface `ShenandoahGeneration`.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename ShenandoahHeapStats -> ShenandoahSpaceInfo

I like this, with two minor nits.

src/hotspot/share/gc/shenandoah/heuristics/shenandoahSpaceInfo.hpp line 26:

> 24: 
> 25: #ifndef SHARE_GC_SHENANDOAH_HEURISTICS_SHENANDOAHHEAPSTATS_HPP
> 26: #define SHARE_GC_SHENANDOAH_HEURISTICS_SHENANDOAHHEAPSTATS_HPP

Include guards still mention the old name.

src/hotspot/share/gc/shenandoah/heuristics/shenandoahSpaceInfo.hpp line 45:

> 43: };
> 44: 
> 45: #endif //SHARE_GC_SHENANDOAH_HEURISTICS_SHENANDOAHHEAPSTATS_HPP

Same as above.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14856#pullrequestreview-1541562277
PR Review Comment: https://git.openjdk.org/jdk/pull/14856#discussion_r1270924734
PR Review Comment: https://git.openjdk.org/jdk/pull/14856#discussion_r1270925228