RFR: 8312502: Mass migrate HotSpot attributes to the correct location [v2]

[Julian Waters]

On Sun, 23 Jul 2023 11:45:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 40 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into patch-6
>>  - arguments.hpp
>>  - arguments.hpp
>>  - globalDefinitions_gcc.hpp
>>  - assembler_aarch64.hpp
>>  - macroAssembler_aarch64.cpp
>>  - vmError.cpp
>>  - vmError.cpp
>>  - macroAssembler_aarch64.cpp
>>  - assembler_aarch64.hpp
>>  - ... and 30 more: https://git.openjdk.org/jdk/compare/624faab5...afff56f2
>
> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 161:
> 
>> 159: #define NOINLINE     [[gnu::noinline]]
>> 160: #define ALWAYSINLINE [[gnu::always_inline]] inline
>> 161: #define ATTRIBUTE_FLATTEN [[gnu::flatten]]
> 
> This is way beyond the described scope of this PR.

I changed these to the standard attributes so the compilers would concretely enforce the checks of which areas the attributes appertained to, as opposed to the regular __attribute__ syntax which don't perform such checks (Same reasoning for the ones in compilerWarnings as well)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14969#discussion_r1271441981