RFR: 8312502: Mass migrate HotSpot attributes to the correct location [v3]

Julian Waters jwaters at openjdk.org
Tue Jul 25 01:45:50 UTC 2023


On Mon, 24 Jul 2023 05:34:04 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Someone had to do it, so I did. Moves attributes to the correct place as specified in the HotSpot Style Guide once and for all
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 41 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-6
>  - Merge branch 'openjdk:master' into patch-6
>  - arguments.hpp
>  - arguments.hpp
>  - globalDefinitions_gcc.hpp
>  - assembler_aarch64.hpp
>  - macroAssembler_aarch64.cpp
>  - vmError.cpp
>  - vmError.cpp
>  - macroAssembler_aarch64.cpp
>  - ... and 31 more: https://git.openjdk.org/jdk/compare/090c3cd9...d60d8923

Hmm... I was doing this so that what attribute specifiers applied to would be clearer since it's helpful to have the ability to make them apply to different aspects of a method as per C++11. Could I split this up and discard some of the areas in which the changes are less agreeable? (as advised by someone who reached out to me privately)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14969#issuecomment-1648839267


More information about the hotspot-gc-dev mailing list