RFR: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal [v4]

[Aleksey Shipilev]

On Tue, 25 Jul 2023 00:35:12 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Code oddities reported by SonarCloud after CMS removal
>> Fix: moving ParallelGCThreadsConstraintFuncParallel to shared code as ParallelGCThreadsConstraintFunc
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adding a comment about overflow range INT_MAX

Ah, see, there is a failing test:
https://github.com/kspeeyu/jdk/actions/runs/5651211226#user-content-gc_arguments_testparallelgcthreads


----------System.err:(22/1299)----------
 stdout: [];
 stderr: [uint ParallelGCThreads=4294967295 is outside the allowed range [ 0 ... 2147483647 ]
Improperly specified VM option 'ParallelGCThreads=4294967295'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
]
 exitValue = 1


We need to adjust that test for new boundary now, I think.

Run it like this:


$ make test TEST=gc/arguments/TestParallelGCThreads.java

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14965#issuecomment-1649927743