RFR: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal [v5]

Aleksey Shipilev shade at openjdk.org
Wed Jul 26 08:47:41 UTC 2023


On Tue, 25 Jul 2023 20:11:18 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Code oddities reported by SonarCloud after CMS removal
>> Fix: moving ParallelGCThreadsConstraintFuncParallel to shared code as ParallelGCThreadsConstraintFunc
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changing ParallelGCThreads count in test

test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java line 116:

> 114:     }
> 115: 
> 116:     // 2147483647 == (signed int) -1

This is not technically correct: `(signed int) -1` is `-1`.
Rewrite the whole comment to: `// Test the max value for ParallelGCThreads`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14965#discussion_r1274589054


More information about the hotspot-gc-dev mailing list