RFR: JDK-8309297: Adjust ShenandoahHeap print_heap_regions_on

Y. Srinivas Ramakrishna ysr at openjdk.org
Fri Jun 2 16:57:07 UTC 2023


On Thu, 1 Jun 2023 14:45:16 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The ShenandoahHeap print_heap_regions_on method prints some brief description of the columns of the heap table, however the description is unsorted and seems to be not fully up to date.
> 
> Another thought - is the critical pins column (CP=critical pins)  still needed or always 0  and obsolete now?

Marked as reviewed by ysr (Reviewer).

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1032:

> 1030:   st->print_cr("S=shared allocs, L=live data");
> 1031:   st->print_cr("CP=critical pins");
> 1032:   //st->print_cr("SN=alloc sequence number");

You can delete this line since what it used to print `_seqnum_last_alloc_mutator` appears to no longer be present in `ShenandoahHeapRegion`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14264#pullrequestreview-1458029253
PR Review Comment: https://git.openjdk.org/jdk/pull/14264#discussion_r1214606446


More information about the hotspot-gc-dev mailing list