RFR: 8140326: G1: Consider putting regions where evacuation failed into next collection set [v2]
Thomas Schatzl
tschatzl at openjdk.org
Mon Jun 5 11:40:08 UTC 2023
On Mon, 5 Jun 2023 10:10:36 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Doc additions
>
> src/hotspot/share/gc/g1/g1CollectionSetChooser.cpp line 153:
>
>> 151: // alloc region (we should not consider those for collection
>> 152: // before we fill them up).
>> 153: if (should_add(r) && !G1CollectedHeap::heap()->is_old_gc_alloc_region(r)) {
>
> Pre-existing: why not move the `!G1CollectedHeap::heap()->is_old_gc_alloc_region(r)` to `should_add` helper?
I already discussed this with @albertnetymk with the result of moving this to a separate commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14220#discussion_r1217944998
More information about the hotspot-gc-dev
mailing list