RFR: 8140326: G1: Consider putting regions where evacuation failed into next collection set [v3]

[Ivan Walulya]

On Mon, 5 Jun 2023 13:19:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1Policy.cpp line 1534:
>> 
>>> 1532: void G1Policy::select_candidates_from_retained(G1CollectionCandidateList* retained_list,
>>> 1533:                                                double time_remaining_ms,
>>> 1534:                                                G1CollectionCandidateRegionList* initial_old_regions,
>> 
>> Might be called on empty `retained_list`, probably better to have an early return. Same should be added to `select_candidates_from_retained`
>
> I would prefer to keep things as is. The overhead isn't big: after some initialization, the main loop will not be entered anyway, but we'd need to duplicate the log messages (or add a special one) in both cases.

Noted!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14220#discussion_r1218147077