RFR: 8272147: Consolidate preserved marks handling with other STW collectors

Albert Mingkun Yang ayang at openjdk.org
Mon Jun 5 16:19:09 UTC 2023


On Thu, 1 Jun 2023 22:32:52 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch removes the class `markSweep.hpp::PreservedMark` and uses the shared `PreservedMarksSet` instead.
> 
> In order to keep the meaning of the field `_preserved_marks` in `markSweep`,
> I need to use `OopAndMarkWord` explicitly. So I move `OopAndMarkWord` out of `PreservedMarks`.
> 
> Tests:
> `hotspot:tier1` passed locally (x86 & linux).
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong

src/hotspot/share/gc/shared/preservedMarks.hpp line 60:

> 58: 
> 59: public:
> 60:   OopAndMarkWordStack& get_stack() { return _stack; }

Could you explain why this new API is required for Serial but not other collectors, e.g. G1? (IOW, can Serial do sth similar as G1 so that no new API is introduced?)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14274#discussion_r1218301433


More information about the hotspot-gc-dev mailing list