RFR: 8309346: Extend hs_err logging for all VM operations deriving from VM_GC_Operation [v3]
Stefan Karlsson
stefank at openjdk.org
Mon Jun 5 16:42:10 UTC 2023
On Mon, 5 Jun 2023 14:50:42 GMT, Daohan Qu <duke at openjdk.org> wrote:
>> This patch implements `cause()` for `VM_GC_Operation` and its derived classes. It follows [JDK-8309210](https://bugs.openjdk.org/browse/JDK-8309210) to provide more detailed info for `VM_GC_Operation`s in hs_err log file.
>
> Daohan Qu has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert the change and leave it for further cleaning up
Could you move the implementation over to the .cpp file? We should strive to not add non-trivial implementation in .hpp files.
-------------
Changes requested by stefank (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14287#pullrequestreview-1462957960
More information about the hotspot-gc-dev
mailing list