RFR: 8309346: Extend hs_err logging for all VM operations deriving from VM_GC_Operation

Daohan Qu duke at openjdk.org
Tue Jun 6 07:35:58 UTC 2023


On Mon, 5 Jun 2023 12:18:46 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> This patch implements `cause()` for `VM_GC_Operation` and its derived classes. It follows [JDK-8309210](https://bugs.openjdk.org/browse/JDK-8309210) to provide more detailed info for `VM_GC_Operation`s in hs_err log file.
>
> (this is not a review) How about using `override` instead of `virtual`? I think it better shows how the method is used, and also create compile time errors if we miss to rename the method during refactoring.

Thanks again for your comments and reviews @lkorinth @tschatzl @stefank !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14287#issuecomment-1578083152


More information about the hotspot-gc-dev mailing list