RFR: 8272147: Consolidate preserved marks handling with other STW collectors

Thomas Schatzl tschatzl at openjdk.org
Tue Jun 6 08:03:53 UTC 2023


On Thu, 1 Jun 2023 22:32:52 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch removes the class `markSweep.hpp::PreservedMark` and uses the shared `PreservedMarksSet` instead.
> 
> In order to keep the meaning of the field `_preserved_marks` in `markSweep`,
> I need to use `OopAndMarkWord` explicitly. So I move `OopAndMarkWord` out of `PreservedMarks`.
> 
> Tests:
> `hotspot:tier1` passed locally (x86 & linux).
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/serial/genMarkSweep.cpp line 51:

> 49: #include "gc/shared/strongRootsScope.hpp"
> 50: #include "gc/shared/weakProcessor.hpp"
> 51: #include "gc/shared/preservedMarks.inline.hpp"

Includes should be ordered alphabetically.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14274#pullrequestreview-1462762622
PR Review Comment: https://git.openjdk.org/jdk/pull/14274#discussion_r1218206815


More information about the hotspot-gc-dev mailing list