RFR: 8272147: Consolidate preserved marks handling with other STW collectors [v2]

Guoxiong Li gli at openjdk.org
Wed Jun 7 12:45:48 UTC 2023


On Wed, 7 Jun 2023 12:03:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/markSweep.cpp line 156:
>> 
>>> 154:     _preserved_marks[_preserved_count++] = OopAndMarkWord(obj, mark);
>>> 155:   } else {
>>> 156:     _preserved_overflow_stack_set.get()->push_if_necessary(obj, mark);
>> 
>> Why not `push_always`? I'd expect this mark must be preserved.
>
> Will fix it later.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14274#discussion_r1221522240


More information about the hotspot-gc-dev mailing list