RFR: 8272147: Consolidate preserved marks handling with other STW collectors [v4]

Albert Mingkun Yang ayang at openjdk.org
Wed Jun 7 20:21:52 UTC 2023


On Wed, 7 Jun 2023 15:43:08 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch removes the class `markSweep.hpp::PreservedMark` and uses the shared `PreservedMarksSet` instead.
>> 
>> In order to keep the meaning of the field `_preserved_marks` in `markSweep`,
>> I need to use `OopAndMarkWord` explicitly. So I move `OopAndMarkWord` out of `PreservedMarks`.
>> 
>> Tests:
>> `hotspot:tier1` passed locally (x86 & linux).
>> 
>> Thanks for the review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add and use 'adjust_preserved_mark'

Marked as reviewed by ayang (Reviewer).

src/hotspot/share/gc/shared/preservedMarks.hpp line 37:

> 35: class WorkerThreads;
> 36: 
> 37: class OopAndMarkWord {

Now that this class is in public domain, I tend to think it should be renamed to `PreservedMark` to be consistent with other classes in this file. (Ofc, this is quite subjective.)

-------------

PR Review: https://git.openjdk.org/jdk/pull/14274#pullrequestreview-1468494515
PR Review Comment: https://git.openjdk.org/jdk/pull/14274#discussion_r1222112692


More information about the hotspot-gc-dev mailing list