RFR: 8309403: Serial: Remove the useless adaptive size policy in GenCollectedHeap [v2]

Guoxiong Li gli at openjdk.org
Thu Jun 8 07:12:57 UTC 2023


On Wed, 7 Jun 2023 20:28:12 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Restore the _should_clear_all_soft_refs in WB_FullGC.
>>  - Merge branch 'master' into JDK-8309403
>>  - JDK-8309403
>
> src/hotspot/share/prims/whitebox.cpp line 1449:
> 
>> 1447:   Universe::heap()->collect(GCCause::_wb_full_gc);
>> 1448: #if defined(INCLUDE_G1GC) || defined(INCLUDE_PARALLELGC) || defined(INCLUDE_SERIALGC)
>> 1449:   if (UseG1GC || UseParallelGC || UseSerialGC) {
> 
> I don't think you can do the same for Parallel due to the presence of `GCOverheadChecker`, which also updates the global var.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14296#discussion_r1222554127


More information about the hotspot-gc-dev mailing list