RFR: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp [v2]

Afshin Zafari azafari at openjdk.org
Thu Jun 8 09:55:48 UTC 2023


On Wed, 7 Jun 2023 15:18:53 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some more intx to int conversions.
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 441:
> 
>> 439: // max_uintx            0xFFFFFFFF      0xFFFFFFFFFFFFFFFF
>> 440: 
>> 441: typedef unsigned int uint;   NEEDS_CLEANUP
> 
> Unrelated, but I wonder why this "NEEDS_CLEANUP"?

Maybe, it is because the `uint` is already defined within the guarded lines 149-154: 
```C++
#ifdef __USE_MISC
/* Old compatibility names for C types.  */
typedef unsigned long int ulong;
typedef unsigned short int ushort;
typedef unsigned int uint;
#endif

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14259#discussion_r1222736817


More information about the hotspot-gc-dev mailing list