RFR: 8309403: Serial: Remove the useless adaptive size policy in GenCollectedHeap [v3]
Albert Mingkun Yang
ayang at openjdk.org
Thu Jun 8 11:05:56 UTC 2023
On Thu, 8 Jun 2023 07:01:11 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> This patch removes the useless code related to the `AdaptiveSizePolicy` in `GenCollectedHeap`.
>> As a result, the `SoftRefGenPolicy` is unnecessary too, use `SoftRefPolicy` instead.
>>
>> Thanks for the review.
>>
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove Parallel GC in 'WB_FullGC'
Marked as reviewed by ayang (Reviewer).
src/hotspot/share/prims/whitebox.cpp line 1448:
> 1446: Universe::heap()->soft_ref_policy()->set_should_clear_all_soft_refs(true);
> 1447: Universe::heap()->collect(GCCause::_wb_full_gc);
> 1448: #if defined(INCLUDE_G1GC) || defined(INCLUDE_SERIALGC)
`INCLUDE_G1GC` can be defined as zero; it's best to treat them as bool vars. The rest look good.
-------------
PR Review: https://git.openjdk.org/jdk/pull/14296#pullrequestreview-1469660583
PR Review Comment: https://git.openjdk.org/jdk/pull/14296#discussion_r1222879646
More information about the hotspot-gc-dev
mailing list