RFR: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp [v3]
Coleen Phillimore
coleenp at openjdk.org
Fri Jun 9 14:48:48 UTC 2023
On Fri, 9 Jun 2023 14:11:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comments applied
>
> src/hotspot/share/gc/shared/gc_globals.hpp line 395:
>
>> 393: product(uint, PausePadding, 1, \
>> 394: "How much buffer to keep for pause time") \
>> 395: range(0, UINT_MAX) \
>
> Why did you change from max_juint -> UINT_MAX ? max_juint should have compile without integer size mismatch.
Or, not in this change, but should we prefer UINT_MAX (found in /usr/include/limits.h) to our globalDefinitions.hpp definitions?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14259#discussion_r1224393681
More information about the hotspot-gc-dev
mailing list