RFR: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Jun 9 14:48:50 UTC 2023


On Fri, 9 Jun 2023 09:02:56 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments applied
>
> src/hotspot/share/gc/shared/gc_globals.hpp line 688:
> 
>> 686:           "Number of entries we will try to leave on the stack "            \
>> 687:           "during parallel gc")                                             \
>> 688:           range(0, SIZE_MAX)                                                \
> 
> This is a large increase in the max on 64bit platforms.

Yes, you should revert the change from max_juint to SIZE_MAX.  Is the change to size_t a cleanup to remove a cast?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14259#discussion_r1224363510


More information about the hotspot-gc-dev mailing list