RFR: 8309627: Incorrect sorting of DirtyCardQueue buffers [v2]

Kim Barrett kbarrett at openjdk.org
Sat Jun 10 17:14:28 UTC 2023


> Please review this simple fix to the sorting of dirty card buffers.  The
> comparison function is using the difference between the card pointer to
> compute the order, but is discarding all but the low 32 bits.
> 
> While I was at it, adjusted the name of the sort function.
> 
> Testing:
> mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into dcq-sort
 - fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14365/files
  - new: https://git.openjdk.org/jdk/pull/14365/files/dadf783d..fbffac70

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14365&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14365&range=00-01

  Stats: 9606 lines in 208 files changed: 8501 ins; 457 del; 648 mod
  Patch: https://git.openjdk.org/jdk/pull/14365.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14365/head:pull/14365

PR: https://git.openjdk.org/jdk/pull/14365


More information about the hotspot-gc-dev mailing list