RFR: 8272147: Consolidate preserved marks handling with other STW collectors [v5]

Guoxiong Li gli at openjdk.org
Mon Jun 12 12:39:29 UTC 2023


On Mon, 12 Jun 2023 09:30:58 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename OopAndMarkWork to PreservedMark.
>
> src/hotspot/share/gc/shared/preservedMarks.hpp line 52:
> 
>> 50: class PreservedMarks {
>> 51: private:
>> 52:   typedef Stack<PreservedMark, mtGC> OopAndMarkWordStack;
> 
> You renamed OopAndMarkWord to PreservedMark, which I like. Maybe you also want to rename OopAndMarkWordStack to PreservedMarkStack? Otherwise it looks confusing I think.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14274#discussion_r1226597663


More information about the hotspot-gc-dev mailing list