RFR: 8140326: G1: Consider putting regions where evacuation failed into next collection set [v4]
Thomas Schatzl
tschatzl at openjdk.org
Tue Jun 13 07:19:43 UTC 2023
On Fri, 9 Jun 2023 13:53:38 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - More debug option removal
>> - Remove debug options for tests
>
> src/hotspot/share/gc/g1/g1Policy.cpp line 516:
>
>> 514: }
>> 515:
>> 516: double G1Policy::predict_retained_regions_evac_time() const {
>
> Seems that the result is only for log-print in its sole caller, `predict_base_time_ms`. However, it's also odd that this method is called there at all.
This is a bug. It's supposed to be used for calculating the total_time in that method too. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14220#discussion_r1227639920
More information about the hotspot-gc-dev
mailing list