RFR: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition [v2]

Stefan Karlsson stefank at openjdk.org
Tue Jun 13 09:16:54 UTC 2023


> There's a section in the test that waits up to 10 seconds for a string to be deduplicated and then does a final verification that the string was correctly deduplicated. However, the initial waiting gets passed the wrong comparison string, which has the effect that this test always waits for 10 seconds before proceeding.
> 
> The problem is here:
> 
>             if (!waitForDeduplication(dupString3, baseString)) {
>                 if (getValue(dupString3) != getValue(internedString)) {
> 
> where the first line should say:
> 
>             if (!waitForDeduplication(dupString3, internedString)) {

Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:

  Review kbarrett

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14437/files
  - new: https://git.openjdk.org/jdk/pull/14437/files/8e402a70..b56e8d0f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14437&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14437&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14437.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14437/head:pull/14437

PR: https://git.openjdk.org/jdk/pull/14437


More information about the hotspot-gc-dev mailing list