Integrated: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition

Stefan Karlsson stefank at openjdk.org
Wed Jun 14 06:33:06 UTC 2023


On Tue, 13 Jun 2023 05:48:32 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> There's a section in the test that waits up to 10 seconds for a string to be deduplicated and then does a final verification that the string was correctly deduplicated. However, the initial waiting gets passed the wrong comparison string, which has the effect that this test always waits for 10 seconds before proceeding.
> 
> The problem is here:
> 
>             if (!waitForDeduplication(dupString3, baseString)) {
>                 if (getValue(dupString3) != getValue(internedString)) {
> 
> where the first line should say:
> 
>             if (!waitForDeduplication(dupString3, internedString)) {

This pull request has now been integrated.

Changeset: 63fe413d
Author:    Stefan Karlsson <stefank at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/63fe413d93861c79af5587859f01822980969c24
Stats:     4 lines in 1 file changed: 0 ins; 2 del; 2 mod

8309890: TestStringDeduplicationInterned.java waits for the wrong condition

Reviewed-by: aboldtch, kbarrett

-------------

PR: https://git.openjdk.org/jdk/pull/14437


More information about the hotspot-gc-dev mailing list