RFR: 8308633: Increase precision of timestamps in g1 log
Albert Mingkun Yang
ayang at openjdk.org
Thu Jun 22 13:52:04 UTC 2023
On Wed, 21 Jun 2023 15:19:41 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this improvement adding a digit to log timestamp to improve output. On modern machines, for some pauses, this can lead to sub-phase timings not adding up, and during development, extra work to evaluate different options.
> Also that rounding error starts to matter for e.g. pauses < a few ms.
>
> I am aware that there is a duplication of the timestamp format in the files, and this change did not improve that as this would be a different issue. Not sure where to put such a global constant though, any suggestions?
>
> Testing: gha, looking at log files
>
> Thanks,
> Thomas
Marked as reviewed by ayang (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/14594#pullrequestreview-1493245098
More information about the hotspot-gc-dev
mailing list