Integrated: 8308633: Increase precision of timestamps in g1 log
Thomas Schatzl
tschatzl at openjdk.org
Mon Jun 26 07:54:14 UTC 2023
On Wed, 21 Jun 2023 15:19:41 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this improvement adding a digit to log timestamp to improve output. On modern machines, for some pauses, this can lead to sub-phase timings not adding up, and during development, extra work to evaluate different options.
> Also that rounding error starts to matter for e.g. pauses < a few ms.
>
> I am aware that there is a duplication of the timestamp format in the files, and this change did not improve that as this would be a different issue. Not sure where to put such a global constant though, any suggestions?
>
> Testing: gha, looking at log files
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: c23794f8
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c23794f88270c121bf99fdf297fdfde53072e3b6
Stats: 13 lines in 4 files changed: 3 ins; 0 del; 10 mod
8308633: Increase precision of timestamps in g1 log
Reviewed-by: ayang, kbarrett
-------------
PR: https://git.openjdk.org/jdk/pull/14594
More information about the hotspot-gc-dev
mailing list