RFR: 8281455: Change JVM options with small ranges from 64 to 32 bits, for gc_globals.hpp [v3]
Afshin Zafari
azafari at openjdk.org
Mon Jun 26 14:03:10 UTC 2023
On Fri, 9 Jun 2023 08:54:50 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comments applied
>
> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 2311:
>
>> 2309: size_t target_size;
>> 2310: if (partially) {
>> 2311: target_size = MIN2((size_t)_task_queue->max_elems()/3, GCDrainStackTargetSize);
>
> I was hoping max_elems() wouldn't need a cast. Fixing that seems like it might be one of those long
> and more complicated threads I was referring to earlier.
The `max_elems()` return `uint` and the cast is needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14259#discussion_r1242251737
More information about the hotspot-gc-dev
mailing list