RFR: 8047998: Abort the vm if MaxNewSize is not the same as NewSize when MaxHeapSize is the same as InitialHeapSize
Albert Mingkun Yang
ayang at openjdk.org
Mon Jun 26 19:53:03 UTC 2023
On Sun, 11 Jun 2023 07:57:01 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>>> The condition MaxHeapSize == InitialHeapSize is often meet
>>
>> True, but additionally specifying both `NewSize` and `MaxNewSize` is uncommon, IMO.
>>
>>> I do worry that such exiting may break some current online systems
>>
>> Actually, I think it's desirable to fail loudly if the JVM cmd flags contain errors. Hard to say whether this is an error or not, but debugging suboptimal performance (from incorrect heap/generation-size) is much harder. Therefore, notifying developers at jvm-startup when cmd flags can't be satisfied might be appreciated. Again, this setup should be rare.
>>
>> (I agree this is subjective.)
>
> @albertnetymk Thanks for creating the CSR. It may be good to mark it as `PROPOSED` now.
@lgxbslgx The CSR has been approved.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13876#issuecomment-1608134833
More information about the hotspot-gc-dev
mailing list