RFR: 8310946: G1: Refactor G1Policy::next_gc_should_be_mixed

Kim Barrett kbarrett at openjdk.org
Fri Jun 30 07:21:53 UTC 2023


On Tue, 27 Jun 2023 11:58:34 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple restructuring around `next_gc_should_be_mixed`.
> 
> (After such refactoring, I also tend to think this predicate makes more sense in the caller context, i.e. `bool is_next_gc_mixed = has_marking_candidates();`. For example, one of the call site even asserts `assert(!candidates()->has_more_marking_candidates(),`. Ofc, this is rather subjective.)
> 
> Test: hotspot_gc

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14673#pullrequestreview-1506647322


More information about the hotspot-gc-dev mailing list