RFR: 8303252: G1: Return early from Full-GC if no regions are selected for compaction. [v4]
Albert Mingkun Yang
ayang at openjdk.org
Wed Mar 1 11:04:07 UTC 2023
On Wed, 1 Mar 2023 09:45:48 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Please review this change to return early from full-gc in case no regions have been selected as targets for compaction.
>> To skip `phase3_adjust_pointers` and `phase4_do_compaction()`, we need to decouple cleanup work that was piggybacked onto these phases. Thus, the `phase5_` is introduced to do the cleanup.
>>
>> Testing: Tier 1-3.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>
> Albert review
I feel phase5 is not on the same abstraction level as others, but can't find a correct place for its content other than `G1FullCollector::complete_collection`. However, I am not sure whether it is strictly better.
-------------
Marked as reviewed by ayang (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12768
More information about the hotspot-gc-dev
mailing list