RFR: 8303334: Further improve liveness/remembered set verification for G1 [v2]

Thomas Schatzl tschatzl at openjdk.org
Thu Mar 2 15:33:15 UTC 2023


On Thu, 2 Mar 2023 13:12:07 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   class -> struct
>
> src/hotspot/share/gc/g1/heapRegion.cpp line 545:
> 
>> 543: 
>> 544:     bool failed() const {
>> 545:       return !_is_in_heap || this->_g1h->is_obj_dead_cond(this->_obj, _vo);
> 
> Not sure why `this->` is there. I think breaking the boundary btw child & super class is fine in this particular patch.

`this->` is required in C++ when accessing the base-class members of inherited template classes. Without this nudge, the compiler does not look up `_g1h` and `_obj` in the template base class and gives a compilation error.

-------------

PR: https://git.openjdk.org/jdk/pull/12807


More information about the hotspot-gc-dev mailing list