RFR: 8303749: Serial: Use more strict card table API
Albert Mingkun Yang
ayang at openjdk.org
Wed Mar 8 15:57:24 UTC 2023
On Wed, 8 Mar 2023 15:23:24 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Simple refactoring to skip an unnecessary guard check.
>>
>> Test: tier1-3
>
> src/hotspot/share/gc/serial/cardTableRS.cpp line 160:
>
>> 158: clear_MemRegion(to_be_cleared_mr);
>> 159: }
>> 160: dirty_MemRegion(used_mr);
>
> Now that `invalidate()` isn't called any more, it might be useful to rename the method to `dirty_or_clear()` or something. In general I think that "dirty" is more specific and clear than "invalidate", but the "invalidate" term probably stems from wanting to be generic (not only here).
> So feel free to ignore this suggestions.
`clear_into_younger` and `invalidate_or_clear/dirty_or_clear` are not very descriptive. I will refactor them in another PR.
-------------
PR: https://git.openjdk.org/jdk/pull/12902
More information about the hotspot-gc-dev
mailing list