RFR: 8303334: Further improve liveness/remembered set verification for G1 [v2]

[Ivan Walulya]

On Thu, 2 Mar 2023 15:15:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this additional refactoring of the liveness/remembered set code? After having pushed [JDK-8302760](https://bugs.openjdk.org/browse/JDK-8302760), @albertnetymk suggested some more changes to improve readability mainly in `G1VerifyLiveAndRememberedSetsClosure` to make program flow more obvious.
>> I.e. it separates the steps of detecting and reporting the failures explicitly.
>> Everything else follows that.
>> 
>> Testing: local compilation, gha, testing on some failure code
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   class -> struct

Lgtm!

Minor nit.

src/hotspot/share/gc/g1/heapRegion.cpp line 589:

> 587: 
> 588:     bool failed() const {
> 589:       if (this->_from != this->_to && !this->_from->is_young() && this->_to->rem_set()->is_complete()) {

Not very consistent with the use  of `this->` on members `_from`  and `_to`

-------------

Marked as reviewed by iwalulya (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12807