Integrated: 8303334: Further improve liveness/remembered set verification for G1

Thomas Schatzl tschatzl at openjdk.org
Thu Mar 9 17:03:28 UTC 2023


On Wed, 1 Mar 2023 15:02:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this additional refactoring of the liveness/remembered set code? After having pushed [JDK-8302760](https://bugs.openjdk.org/browse/JDK-8302760), @albertnetymk suggested some more changes to improve readability mainly in `G1VerifyLiveAndRememberedSetsClosure` to make program flow more obvious.
> I.e. it separates the steps of detecting and reporting the failures explicitly.
> Everything else follows that.
> 
> Testing: local compilation, gha, testing on some failure code
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: 68b5eef4
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/68b5eef44f28ce603a8796545dfa4d3558659bdf
Stats:     126 lines in 1 file changed: 62 ins; 21 del; 43 mod

8303334: Further improve liveness/remembered set verification for G1

Reviewed-by: ayang, iwalulya

-------------

PR: https://git.openjdk.org/jdk/pull/12807


More information about the hotspot-gc-dev mailing list