RFR: 8304015: G1: Metaspace-induced GCs should not trigger maximal compaction

Ivan Walulya iwalulya at openjdk.org
Tue Mar 14 10:46:33 UTC 2023


On Mon, 13 Mar 2023 11:37:36 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this small cleanup to remove triggering maximal compaction on Metaspace-induced full-GCs.
>> 
>> Testing: Tier1.
>
> I think it's better to keep the var so that the semantic of the literal boolean is clear in this context.
> 
> (Slightly off the PR -- it's not obvious that metaspace related GC enters this path. Why isn't the decision on what GC cycle (young/old/clear-soft-or-not) to trigger made inside GC code?)

Thanks @albertnetymk and @tschatzl for the reviews!

-------------

PR: https://git.openjdk.org/jdk/pull/12987


More information about the hotspot-gc-dev mailing list