RFR: 8304393: Provide method to iterate over regions of humongous object in G1 [v2]

Ivan Walulya iwalulya at openjdk.org
Mon Mar 20 10:44:23 UTC 2023


On Fri, 17 Mar 2023 18:08:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this refactoring that introduces a method to iterate over all regions of a humongous object and apply a function to it to decrease the five times code duplication.
>> 
>> Testing: gha
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Indentation

Lgtm!

Minor nit:

src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp line 115:

> 113: 
> 114: template <typename Functor>
> 115: inline void G1CollectedHeap::humongous_obj_regions_iterate(HeapRegion* start, Functor&& f) {

Forwarding reference might be overkill for this case, `const Functor&` should be just fine.

-------------

Marked as reviewed by iwalulya (Reviewer).

PR: https://git.openjdk.org/jdk/pull/13080


More information about the hotspot-gc-dev mailing list