RFR: 8304711: Combine G1 root region abort and wait into a single method

Albert Mingkun Yang ayang at openjdk.org
Wed Mar 22 18:21:48 UTC 2023


On Wed, 22 Mar 2023 15:59:15 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   merge root region scan and abort calls into a single method as they are used together twice; this also helps with [JDK-8300770](https://bugs.openjdk.org/browse/JDK-8300770) later.
> 
> Testing: gha
> 
> Thanks,
>   Thomas

Marked as reviewed by ayang (Reviewer).

src/hotspot/share/gc/g1/g1ConcurrentMark.hpp line 484:

> 482:   void humongous_object_eagerly_reclaimed(HeapRegion* r);
> 483:   // Notification for old gen regions to clean up.
> 484:   void old_region_reclaimed(HeapRegion* r);

Why this decl? The rest look good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13145#pullrequestreview-1353224011
PR Review Comment: https://git.openjdk.org/jdk/pull/13145#discussion_r1145237927


More information about the hotspot-gc-dev mailing list