RFR: 8304716: Clean up G1Policy::calc_max_old_cset_length() [v2]

Albert Mingkun Yang ayang at openjdk.org
Thu Mar 23 11:31:43 UTC 2023


On Thu, 23 Mar 2023 09:34:22 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this simplification of `G1Policy::calc_max_old_cset_length()`. It does not seem important to be clever here.
>> 
>> Depends on #13147.
>> 
>> Testing: gha
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ayang review, break formula a bit

src/hotspot/share/gc/g1/g1Policy.cpp line 1403:

> 1401:   // number of old regions added to the CSet irrespective of how many
> 1402:   // of them are available.
> 1403:   double result = (double)_g1h->num_regions() * (size_t)G1OldCSetRegionThresholdPercent / 100;

Why `size_t` here? I'd expect everything is `double` on this line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13148#discussion_r1146044655


More information about the hotspot-gc-dev mailing list