RFR: 8304802: After JDK-8297639 the flag G1UsePreventiveGC needs to be added to the obsoletion table
David Holmes
dholmes at openjdk.org
Fri Mar 24 04:09:30 UTC 2023
On Thu, 23 Mar 2023 10:38:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this change that puts the `G1UsePreventiveGC` into the argument obsoletion table so that the appropriate warning is printed when starting the VM with that option. Functionality has already been removed, and CSR request approved with [JDK-8297639](https://bugs.openjdk.org/browse/JDK-8297639).
>
> Testing: local compilation, manual testing that the obsoletion warning is printed on the command line.
>
> Thanks,
> Thomas
Ah never mind - it is a diagnostic flag so no CSR needed anyway.
Looks good. Thanks
src/hotspot/share/gc/g1/g1_globals.hpp line 116:
> 114: range(1, max_intx) \
> 115: \
> 116: product(uint, G1ConfidencePercent, 50, \
Seems unrelated
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13156#pullrequestreview-1355971765
PR Review Comment: https://git.openjdk.org/jdk/pull/13156#discussion_r1147097118
More information about the hotspot-gc-dev
mailing list