RFR: 8304412: Serial: Refactor old generation cards update after Full GC [v2]

Thomas Schatzl tschatzl at openjdk.org
Fri Mar 24 12:37:35 UTC 2023


On Thu, 23 Mar 2023 16:05:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple refactoring to use more informative names/comments.
>> 
>> Test: tier1-6
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - review
>  - s1-card-table-refactor

lgtm. Please consider moving the comment.

src/hotspot/share/gc/serial/genMarkSweep.cpp line 115:

> 113:   // the old generation card table completely if the young generation had been
> 114:   // completely evacuated, otherwise dirties the whole old generation to
> 115:   // conservatively not loose any old-to-young pointer.

I was actually thinking of putting this into the hpp file at the declaration of the method.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13076#pullrequestreview-1356608290
PR Review Comment: https://git.openjdk.org/jdk/pull/13076#discussion_r1147523204


More information about the hotspot-gc-dev mailing list