RFR: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC
Aleksey Shipilev
shade at openjdk.org
Fri Mar 24 16:14:24 UTC 2023
On Fri, 24 Mar 2023 15:27:53 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
> I suggest to remove this code for the following reasons:
> - It doesn't work with ZGC (oop needs to go through load barrier, see JBS issue).
> - It generates too much code. Loading oops is quite common and the oop verification code is quite lengthy.
> - Other platforms don't have it, either.
So this `check_oop` happens too early after the load, right?
There are also `VerifyOops` blocks for stores in the same file, would you like to handle those as well? These oops should be okay with most GCs, but the point about the code size stands. Other platforms do not have the checks on those paths too, AFAICS.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13175#issuecomment-1483061365
More information about the hotspot-gc-dev
mailing list