RFR: 8057586: Explicit GC ignored if GCLocker is active [v3]

Ivan Walulya iwalulya at openjdk.org
Thu Mar 30 13:46:44 UTC 2023


On Thu, 30 Mar 2023 13:38:39 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> `full_gc_count != total_full_collections` is under locker-scope, so we can avoid that locking since we are sure at this point that gc_count was incremented.
>
> True, but this is not a perf-critical method, be consistent (with other gcs) is more important, IMO.

Only Serial doesn't have this early return, and only reason I didn't add it is because PR was getting too big and serial required a lot more changes to have this implemented. So i think It will added later for Serial GC.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13191#discussion_r1153286893


More information about the hotspot-gc-dev mailing list