RFR: 8305233: G1: Refactor G1ClearCardTableTask

Thomas Schatzl tschatzl at openjdk.org
Fri Mar 31 14:47:15 UTC 2023


On Thu, 30 Mar 2023 10:38:29 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple refactoring for better encapsulation.
> 
> Test: hotspot_gc

Lgtm.

src/hotspot/share/gc/g1/g1RemSet.cpp line 243:

> 241: 
> 242:     void do_work(uint worker_id) override {
> 243:       const uint num_regions_per_worker = num_cards_per_worker / (uint) HeapRegion::CardsPerRegion;

Suggestion:

      const uint num_regions_per_worker = num_cards_per_worker / (uint)HeapRegion::CardsPerRegion;

Superfluous whitespace.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13242#pullrequestreview-1367080702
PR Review Comment: https://git.openjdk.org/jdk/pull/13242#discussion_r1154565688


More information about the hotspot-gc-dev mailing list