RFR: 8305896: Alternative full GC forwarding [v16]

Aleksey Shipilev shade at openjdk.org
Tue May 2 17:37:31 UTC 2023


On Tue, 2 May 2023 14:23:36 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address @shipilev's review
>
> src/hotspot/share/gc/shared/slidingForwarding.inline.hpp line 56:
> 
>> 54:     // Primary is free
>> 55:     _bases_table[base_idx] = to_region_base;
>> 56:   } else if (region_contains(_bases_table[base_idx], to)) {
> 
> Stupid question, could this not just be `else if ( _bases_table[base_idx] == to_region_base)` ? Same below?

(kicks himself a little). Yes. Yes, it can. We would not need `region_contains` method then at all, I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13582#discussion_r1182826854


More information about the hotspot-gc-dev mailing list