RFR: 8307348 - Parallelize heap walk for ObjectCount(AfterGC) JFR event collection [v3]
olivergillespie
duke at openjdk.org
Wed May 3 12:16:14 UTC 2023
On Wed, 3 May 2023 12:03:44 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Why not just `hi.populate_table(&cit, is_alive_cl, ParallelGCThreads);`, and let the `populate_table` deal with the rest? I think we have a convention that `ParallelGCThreads` is roughly the proxy for the number of GC threads at paused operation.
>
> (It is weird that `HeapInspection::populate_table` uses `safepoint_workers` -- maybe that's for additional isolation from the GC threads -- let's not proliferate it here. `populate_table` also caps the worker count at `max_workers`, which answers one of your questions)
Thanks, that's fine by me, whatever is most idiomatic. Updated.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13774#issuecomment-1532917696
More information about the hotspot-gc-dev
mailing list