RFR: 8307348 - Parallelize heap walk for ObjectCount(AfterGC) JFR event collection [v4]

Thu May 4 15:41:14 UTC 2023

On Thu, 4 May 2023 15:09:52 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Actually I'm not sure why safepoint_workers are used at all.

I believe it's semantically incorrect to use `safepoint_workers` here. Maybe `HeapInspection` should live in `gc` folder.

> The changes to do that does not seem to be that significant to me actually, so I would prefer that.

How does that affect another caller, `VM_GC_HeapInspection::doit`? Unclear to me how one can get gc-workers in that context.

Could one introduce another API in `class CollectedHeap`, sth like `virtual WorkerThreads* gc_workers() { return nullptr; }`, next to `safepoint_workers`?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13774#issuecomment-1535000662