RFR: 8307348 - Parallelize heap walk for ObjectCount(AfterGC) JFR event collection [v6]
olivergillespie
duke at openjdk.org
Fri May 5 13:05:30 UTC 2023
On Fri, 5 May 2023 12:14:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> olivergillespie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix imports
>
> src/hotspot/share/memory/heapInspection.cpp line 569:
>
>> 567: uintx HeapInspection::populate_table(KlassInfoTable* cit, BoolObjectClosure *filter, WorkerThreads* workers) {
>> 568: // Try parallel first.
>> 569: ResourceMark rm;
>
> I think this `ResourceMark` should remain at both blocks. So that on failed exit from the parallel block, we rollback resource allocations and start over with serial walk.
Ah okay, I didn't understand it before, my bad. Updated, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13774#discussion_r1186064507
More information about the hotspot-gc-dev
mailing list